Skip to content

[9.0] Move the logic out of the server (cleaning and deleting jobs)#8244

Merged
fstagni merged 6 commits into
DIRACGrid:integrationfrom
fstagni:90_logic_JMX
Jul 17, 2025
Merged

[9.0] Move the logic out of the server (cleaning and deleting jobs)#8244
fstagni merged 6 commits into
DIRACGrid:integrationfrom
fstagni:90_logic_JMX

Conversation

@fstagni

@fstagni fstagni commented Jul 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR moves the "logic" for killing and deleting jobs from the JobManagerHandler to a new utility "JobAdministration". Few reasons:

  • Agents can now use that extracted logic directly, without having to call a RPC, thus being faster
  • the DIRAC JobManager service become simpler, and can be more easily ported to diracx
  • The extracted logic can be more easily adopted in diracx

BEGINRELEASENOTES

*WMS
CHANGE: move the logic for jobs deleting and killing in an utility

ENDRELEASENOTES

@fstagni fstagni force-pushed the 90_logic_JMX branch 3 times, most recently from 4fdb1fd to 45ae0b4 Compare July 8, 2025 15:54
@fstagni fstagni changed the title [WIP] 90 logic jmx [9.0] Move the logic out of the server (cleaning and deleting jobs) Jul 8, 2025
@fstagni fstagni force-pushed the 90_logic_JMX branch 6 times, most recently from 65d05fb to 4a55b80 Compare July 14, 2025 14:47
@fstagni fstagni marked this pull request as ready for review July 14, 2025 14:47
@fstagni fstagni requested a review from atsareg as a code owner July 14, 2025 14:47
aldbr
aldbr reviewed Jul 15, 2025
View reviewed changes
Comment thread src/DIRAC/WorkloadManagementSystem/Agent/JobCleaningAgent.py
@aldbr

aldbr commented Jul 15, 2025

Copy link
Copy Markdown
Contributor

Also may be you can add a description in the PR briefly explaining why you are moving parts of the logic out of the DIRAC services for the other reviewers 😅

@fstagni

fstagni commented Jul 15, 2025

Copy link
Copy Markdown
Contributor Author

Also may be you can add a description in the PR briefly explaining why you are moving parts of the logic out of the DIRAC services for the other reviewers 😅

Done

@aldbr aldbr mentioned this pull request Jul 15, 2025
Open
@fstagni fstagni merged commit 2828495 into DIRACGrid:integration Jul 17, 2025
37 of 40 checks passed
@DIRACGridBot DIRACGridBot added the sweep:ignore Prevent sweeping from being ran for this PR label Jul 17, 2025
@Robin-Van-de-Merghel Robin-Van-de-Merghel mentioned this pull request Jul 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aldbr aldbr aldbr approved these changes
@atsareg atsareg Awaiting requested review from atsareg atsareg is a code owner

Assignees

No one assigned

Labels

sweep:ignore Prevent sweeping from being ran for this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fstagni @aldbr @DIRACGridBot